Skip to content

Improve Option::select() return type #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Option::select() return type #76

wants to merge 1 commit into from

Conversation

axlon
Copy link

@axlon axlon commented Aug 11, 2024

This change adds a minor improvement to the return type of Option::select() for static analysis.

/** @var \PhpOption\Option<1|2|3> $option */
-PHPStan\dumpType($option->select(2)); // PhpOption\Option<1|2|3>
+PHPStan\dumpType($option->select(2)); // PhpOption\Option<2>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ojhaujjwal ojhaujjwal ojhaujjwal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axlon @ojhaujjwal